fix new keyword broken by recent refactoring#9377
Merged
danez merged 1 commit intobabel:masterfrom Jan 22, 2019
danez:fix-types
Merged
fix new keyword broken by recent refactoring#9377danez merged 1 commit intobabel:masterfrom danez:fix-types
danez merged 1 commit intobabel:masterfrom
danez:fix-types
Conversation
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/9852/ |
1 similar comment
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/9852/ |
nicolo-ribaudo
approved these changes
Jan 22, 2019
loganfsmyth
reviewed
Jan 22, 2019
| while: makeKeywordProps("while", { isLoop }), | ||
| with: makeKeywordProps("with"), | ||
| new: makeKeywordProps("new"), | ||
| new: makeKeywordProps("new", { beforeExpr, startsExpr }), |
Member
There was a problem hiding this comment.
I really hate this beforeExpr system, it makes it so easy to regress like this :(
Member
Author
There was a problem hiding this comment.
This whole sweet.js-context-algorithm (which I think this flags belong to) is so fragile and error prone and doesn't catch a lot of the edge cases. :/ Would be nice to come up with something more robust.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copy and paste error