Refactor import and export parsing#9326
Merged
nicolo-ribaudo merged 3 commits intobabel:masterfrom Jan 22, 2019
Merged
Conversation
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/9776/ |
Member
Author
|
The actual placeholders (which depend on this PR) are implemented at nicolo-ribaudo/babel@placeholders/refactor-import-export...nicolo-ribaudo:placeholders/1-parser |
existentialism
approved these changes
Jan 22, 2019
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While experimenting with #9112, I found out that I needed to hook into some parts of
import/exportparsing to disambiguate, for exampleexport %%FOO%%andexport %%FOO%% from "path".Since I'm working on #9112 using a plugin in a separate file (like we do for JSX or Flow), I can only replace logic overriding methods. With those monolithic
parseExport/parseImportfunctions it is impossible without duplicating a lot of logic: for this reason I has to split them into multiple parts. While I was there, I fixed flow typings as noted in a comment before theparseExportfunction.I'm not putting this changes in the PR I'm preparing for placeholders because they are not strictly related.