Disallow super inside base classes#9316
Closed
nicolo-ribaudo wants to merge 1 commit intobabel:masterfrom
Closed
Conversation
Member
nicolo-ribaudo
commented
Jan 11, 2019
| Q | A |
|---|---|
| Fixed Issues? | |
| Patch: Bug Fix? | Yes |
| Major: Breaking Change? | |
| Minor: New Feature? | |
| Tests Added + Pass? | Yes |
| Documentation PR Link | |
| Any Dependency Changes? | |
| License | MIT |
nicolo-ribaudo
commented
Jan 11, 2019
| inDerived: boolean, | ||
| ) { | ||
| const oldInDerivedClass = this.state.inDerivedClass; | ||
| this.state.inDerivedClass = inDerived; |
Member
Author
There was a problem hiding this comment.
All this things would be a nice usecase for a decorator, if we want to experiment with it. Probably it could even be removed at compile time to generate the current code, so that we avoid the runtime overhead.
class Parser {
// ...
@saveState("inDerivedClass")
pushClassPrivateProperty(
classBody: N.ClassBody,
prop: N.ClassPrivateProperty,
inDerived: boolean,
) {
this.state.inDerivedClass = inDerived;
this.expectPlugin("classPrivateProperties", prop.key.start);
classBody.body.push(this.parseClassPrivateProperty(prop));
}
// ...
}
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/9782/ |
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/9765/ |
4dd0f4d to
29b1625
Compare
29b1625 to
3ff6e21
Compare
Member
Author
|
Replaced by #9493 |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.