Skip to content

Correctly transform spreads of arrays with holes#9146

Closed
phapp88 wants to merge 1 commit into
babel:masterfrom
phapp88:fix-transform-spread-arrays-with-holes
Closed

Correctly transform spreads of arrays with holes#9146
phapp88 wants to merge 1 commit into
babel:masterfrom
phapp88:fix-transform-spread-arrays-with-holes

Conversation

@phapp88

@phapp88 phapp88 commented Dec 7, 2018

Copy link
Copy Markdown
Contributor
Q                       A
Fixed Issues? Fixes #8874
Patch: Bug Fix? Yes
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

This pull request removes holes from spreads of nested arrays and replaces them with undefined.

@nicolo-ribaudo nicolo-ribaudo added the PR: Bug Fix 🐛 A type of pull request used for our changelog categories label Jun 9, 2021
@nicolo-ribaudo

Copy link
Copy Markdown
Member

I rebased this at #13439. I'm really sorry that this straightforward fix got ignored for years 😓

@github-actions github-actions Bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Sep 9, 2021
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Sep 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Bug Fix 🐛 A type of pull request used for our changelog categories

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hole array spread inside of another array isn't work correctly

2 participants