[static private] Unify loose handling of static and instance props#8614
Merged
nicolo-ribaudo merged 1 commit intobabel:masterfrom Sep 4, 2018
Merged
Conversation
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/9007/ |
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/8995/ |
0c59494 to
d4d7021
Compare
jridgewell
approved these changes
Sep 4, 2018
5 tasks
This was referenced Sep 18, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #8205
Since both static and instance private props are defined a non-configurable non-enumerable properties on their target, thay can be handled in the same way.
This PR also removes a possible conflict between private and public static properties, by using the
classPrivateFieldLooseKeyhelper to generate the key (instead of"_" + name). e.g.cc @rricard @jridgewell