Skip to content

Expose opt-in useESModules:"auto" from transform-runtime to toggle based on 'supportsStaticESM'#8520

Merged
loganfsmyth merged 1 commit intobabel:masterfrom
loganfsmyth:runtime-module-usage
Aug 24, 2018
Merged

Expose opt-in useESModules:"auto" from transform-runtime to toggle based on 'supportsStaticESM'#8520
loganfsmyth merged 1 commit intobabel:masterfrom
loganfsmyth:runtime-module-usage

Conversation

@loganfsmyth
Copy link
Copy Markdown
Member

@loganfsmyth loganfsmyth commented Aug 23, 2018

Q                       A
Fixed Issues? Refs #8516
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

This doesn't make the behavior the default, but it does implement the automatic behavior requested in #8516, if you opt into it.

See #8516 (comment) for my concerns about making this the default.

@loganfsmyth loganfsmyth added the PR: New Feature 🚀 A type of pull request used for our changelog categories label Aug 23, 2018
@babel-bot
Copy link
Copy Markdown
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/8897/

1 similar comment
@babel-bot
Copy link
Copy Markdown
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/8897/

@loganfsmyth loganfsmyth changed the title Use supportsStaticESM to toggle runtime module usage. Expose optional useESModules:"auto" from transform-runtime to toggle based on 'supportsStaticESM' Aug 23, 2018
@loganfsmyth loganfsmyth changed the title Expose optional useESModules:"auto" from transform-runtime to toggle based on 'supportsStaticESM' Expose opt-in useESModules:"auto" from transform-runtime to toggle based on 'supportsStaticESM' Aug 23, 2018
Copy link
Copy Markdown
Member

@hzoo hzoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hard to keep up with docs haha

@hzoo hzoo added this to the Babel 7 milestone Aug 24, 2018
@loganfsmyth loganfsmyth merged commit 39fa102 into babel:master Aug 24, 2018
@loganfsmyth loganfsmyth deleted the runtime-module-usage branch August 24, 2018 17:48
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 4, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: New Feature 🚀 A type of pull request used for our changelog categories

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants