Fix trailingComments for FunctionExpression that is CallExpression arguments#8488
Merged
existentialism merged 2 commits intobabel:masterfrom Aug 21, 2018
Merged
Conversation
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/8868/ |
nicolo-ribaudo
approved these changes
Aug 19, 2018
Member
|
Can we add a test? |
existentialism
approved these changes
Aug 21, 2018
Member
existentialism
left a comment
There was a problem hiding this comment.
Pushed a test, will land after CI!
Member
|
@jiaxuan thanks for the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'd very much prefer
Array.filterto for loop. I left it there to be consistent with the case forObjectPropertybefore this.