Skip to content

remove emojis from cli output#8250

Merged
nicolo-ribaudo merged 1 commit intobabel:masterfrom
johnbuffington:emoji-removal
Jul 2, 2018
Merged

remove emojis from cli output#8250
nicolo-ribaudo merged 1 commit intobabel:masterfrom
johnbuffington:emoji-removal

Conversation

@johnbuffington
Copy link
Copy Markdown
Contributor

Q                       A
Fixed Issues? Fixes #8243
Patch: Bug Fix? no
Major: Breaking Change? no
Minor: New Feature? yes
Tests Added + Pass? Yes
Documentation PR no
Any Dependency Changes? no
License MIT

These changes fix display issues on some terminals caused by the use of emojis in output. emojis have been removed from cli package as well as preset-env package

@johnbuffington johnbuffington changed the title remove emojis from cli output (#8243) remove emojis from cli output Jul 2, 2018
@babel-bot
Copy link
Copy Markdown
Collaborator

babel-bot commented Jul 2, 2018

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/8472/

Copy link
Copy Markdown
Member

@xtuc xtuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@nicolo-ribaudo nicolo-ribaudo merged commit 236bd93 into babel:master Jul 2, 2018
@nicolo-ribaudo
Copy link
Copy Markdown
Member

Thank you! 🙂 (⚰️🎉)

@brainkim
Copy link
Copy Markdown

brainkim commented Jul 2, 2018

🎊👅💋🙆‍♀️🙇‍♂️🦄🌈⭐️🏄‍♂️💰🍆💦😓:) thank you!

@xtuc xtuc added PR: Polish 💅 A type of pull request used for our changelog categories pkg: cli labels Jul 4, 2018
@johnbuffington johnbuffington deleted the emoji-removal branch July 20, 2018 05:36
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 4, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: cli PR: Polish 💅 A type of pull request used for our changelog categories

Projects

None yet

Development

Successfully merging this pull request may close these issues.

disable emojis in cli output

5 participants