[WIP] Add support for decorators with private properties#8248
Closed
nicolo-ribaudo wants to merge 34 commits intobabel:masterfrom
Closed
[WIP] Add support for decorators with private properties#8248nicolo-ribaudo wants to merge 34 commits intobabel:masterfrom
nicolo-ribaudo wants to merge 34 commits intobabel:masterfrom
Conversation
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/8720/ |
458857c to
ef8de88
Compare
|
Great work! You might want to change the repl link in the description above to point to the newer build at https://babeljs.io/repl/build/8593/ . |
This has a few advantages: 1) GitHub highlights the helper code, making it easier to review 2) ESLint <3 (it caught an undeclared variable) I also added flow types to help understanding what the functions do. Thanks @Kovensky for the idea!
NOTE: This doesn't work for decorators inside the class body, like in
babel#8300
ef8de88 to
3f703ad
Compare
5 tasks
Member
Author
|
This PR is too outdated, I will open a new one |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I opened this PR before getting the other one merged because I wanted to test what decorated private fields are capable of in the repl 😝
Example: repl
As usual, I will slit this PR in multiple smaller ones. This is mainly to show how things work together and how
@babel/plugin-proposal-enhanced-classes(from #8130) is useful.Depends on #7976 and #8130 (many commits in this PR are actually from those PRs).