Implement MemberExpressionToFunctions helper#7763
Merged
jridgewell merged 6 commits intobabel:masterfrom Apr 21, 2018
Merged
Conversation
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/7663/ |
xtuc
reviewed
Apr 21, 2018
|
|
||
| ## Usage | ||
|
|
||
| TODO |
Member
There was a problem hiding this comment.
I don't think we are actually going to document it. We could just mention: internal usage only?
| @@ -0,0 +1,13 @@ | |||
| { | |||
| "name": "@babel/helper-member-expression-to-functions", | |||
Member
There was a problem hiding this comment.
Author is missing. I guess you can put your name into it?
Fixes babel#7733. This will also be used to simplify the Private Fields transform, which had [almost the same code](https://github.com/CodingItWrong/babel/blob/ccd941057ab297c0f80cacb7c89e892f58e92b00/packages/babel-plugin-proposal-class-properties/src/index.js#L114-L217) hand written.
This can't be redefined, unlike the `Number` identifier.
412d47e to
446a9b8
Compare
446a9b8 to
c1b86c0
Compare
hzoo
approved these changes
Apr 21, 2018
nicolo-ribaudo
approved these changes
Apr 21, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7733.
This will also be used to simplify the Private Fields transform, which had almost the same code hand written.