Merged
Conversation
Co-authored-by: CodingItWrong
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/7452/ |
| this.semicolon(); | ||
| } | ||
|
|
||
| export function ClassPrivateProperty(node: Object) { |
Member
There was a problem hiding this comment.
This should also print the decorators. Also, do Flow and Ts support type annotations?
Member
Author
There was a problem hiding this comment.
I'll leave that for later PRs. Small bits, so we don't get stalled again.
| validate: assertNodeType("PrivateName"), | ||
| }, | ||
| value: { | ||
| validate: assertNodeType("Expression"), |
existentialism
approved these changes
Apr 5, 2018
Member
existentialism
left a comment
There was a problem hiding this comment.
LGTM, I think babel-types docs need to be regen'd after setting it setting ClassPrivateProperty to optional
nicolo-ribaudo
approved these changes
Apr 5, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Co-authored-by: @CodingItWrong
We keep getting stalled on Class Private Properties. This is an attempt to take all the small parts into a separate PR, so we can make some progress.
Part of #7555.