Use helper-module-imports instead of custom import (#7457)#7534
Closed
Swatto wants to merge 1 commit intobabel:masterfrom
Closed
Use helper-module-imports instead of custom import (#7457)#7534Swatto wants to merge 1 commit intobabel:masterfrom
Swatto wants to merge 1 commit intobabel:masterfrom
Conversation
Andarist
reviewed
Mar 9, 2018
| isPolyfillSource(path.node.expression.arguments[0].value); | ||
|
|
||
| const modulePathMap = { | ||
| "regenerator-runtime": "regenerator-runtime/runtime", |
Member
There was a problem hiding this comment.
u've removed this mapping, should be preserved for now
Andarist
reviewed
Mar 9, 2018
| }; | ||
|
|
||
| export const getModulePath = (mod: string) => | ||
| modulePathMap[mod] || `core-js/modules/${mod}`; |
Member
There was a problem hiding this comment.
this got removed to - you should prepend core-js to what you import
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some tests are not passing related to the entry plugin. Will fix that soon.