Skip to content

Uses require instead of default import when transpiling#7468

Closed
debugpai wants to merge 1 commit intobabel:masterfrom
debugpai:use-require-7457
Closed

Uses require instead of default import when transpiling#7468
debugpai wants to merge 1 commit intobabel:masterfrom
debugpai:use-require-7457

Conversation

@debugpai
Copy link
Copy Markdown
Contributor

@debugpai debugpai commented Mar 2, 2018

Fixes #7457

Q                       A
Fixed Issues? Fixes #7457
Major: Breaking Change? No
Minor: New Feature? No
Tests Added + Pass? Yes
Documentation PR No
Any Dependency Changes? No
License MIT

@debugpai debugpai changed the title Uses require instead of default import when transpiling polyfill. Uses require instead of default import when transpiling Mar 2, 2018
@babel-bot
Copy link
Copy Markdown
Collaborator

babel-bot commented Mar 2, 2018

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/7044/

@existentialism
Copy link
Copy Markdown
Member

@debugpai2 thanks for the pr! we don't want to hardcode require statements, and should instead replace preset-env's createImport with /packages/babel-helper-module-imports/README.md@master, so that it can use require/import depending on sourceType.

@hzoo hzoo closed this in #7562 Mar 15, 2018
@debugpai debugpai deleted the use-require-7457 branch March 16, 2018 15:48
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 5, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated A closed issue/PR that is archived due to age. Recommended to make a new issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Env 7 / Node 4 useBuiltIns usage transpiling polyfill call with "import" not "require"

4 participants