Use new Array instead of Array for V8 optimization#6250
Merged
jridgewell merged 3 commits intobabel:masterfrom Sep 18, 2017
Merged
Use new Array instead of Array for V8 optimization#6250jridgewell merged 3 commits intobabel:masterfrom
jridgewell merged 3 commits intobabel:masterfrom
Conversation
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/4919/ |
jridgewell
approved these changes
Sep 15, 2017
hzoo
reviewed
Sep 15, 2017
| @@ -1,3 +1,5 @@ | |||
| "use strict"; | |||
Contributor
Author
There was a problem hiding this comment.
It was auto inserted when I ran make fix. I missed it while committing, my bad.
Member
There was a problem hiding this comment.
oh it must be after @loganfsmyth's helpers PR - maybe modules/import related?
Member
There was a problem hiding this comment.
Oh woops, that's from 2801bfe, looks like we were using it in https://github.com/babel/babel/blob/master/packages/babel-runtime/scripts/build-dist.js#L63
Let me push a fix and remove these changes.
Member
There was a problem hiding this comment.
Fixed f35cf81, so you can remove these changes from the PR now.
existentialism
approved these changes
Sep 15, 2017
Member
mathiasbynens
approved these changes
Sep 18, 2017
Member
|
nice work @pranavpr 👌! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use
new Arrayinstead ofArrayfor array initialization for V8 optimization to kick in.