Conversation
09c4ee0 to
8a8e356
Compare
Actually thats a good point, we may want to figure that out too (in a later pr/change) - should be split? |
|
Sorry will need to do a rebase/fix conflicts since we modified class properties in #6076 |
61225ee to
fadb46c
Compare
|
rebased and fixed conflicts! |
| # babel-plugin-transform-export-default | ||
|
|
||
| > Compile additional export-from statements to ES2015 | ||
| > Compile additional export-default-from statements to ES2015 |
There was a problem hiding this comment.
Nit: can probably drop the "additional" bit?
| "babel-plugin-transform-class-properties": "7.0.0-alpha.19", | ||
| "babel-plugin-transform-function-sent": "7.0.0-alpha.19", | ||
| "babel-plugin-transform-numeric-separator": "7.0.0-alpha.19", | ||
| "babel-plugin-transform-export-namespace": "7.0.0-alpha.19", |
existentialism
left a comment
There was a problem hiding this comment.
Two super small nits, but 👍
|
If you want we could make the old name use the 2 new plugins and deprecate it to say you should use the new one but dono if we want to do that (that only is a thing if they are using the actual name vs the preset) |
6da3317 to
14df0b5
Compare
|
@hzoo Let me clarify a little bit. So what you've suggested is that we'd better remain old plugin named |
14df0b5 to
6f7a5ec
Compare
|
Thanks @echo304, this is great! Yeah I was thinking we the old plugin would just include both but we would deprecate it (we don't have to do this). Or we just make the new plugin error and say you have to include either of the new plugins. |
#6075
Split
babel-plugin-transform-export-extensionsinto two while keepingbabel-plugin-syntax-export-extensionsbabel-plugin-transform-export-defaultbabel-plugin-transform-export-namespace