Skip to content

Add numeric separator to stage 2 preset#6071

Merged
hzoo merged 1 commit intobabel:7.0from
rwaldron:bump_numeric_separator_stage_2
Aug 10, 2017
Merged

Add numeric separator to stage 2 preset#6071
hzoo merged 1 commit intobabel:7.0from
rwaldron:bump_numeric_separator_stage_2

Conversation

@rwaldron
Copy link
Copy Markdown
Contributor

@rwaldron rwaldron commented Aug 8, 2017

Q A
Patch: Bug Fix? No
Major: Breaking Change? No
Minor: New Feature? No
Deprecations? No
Spec Compliancy? Yes
Tests Pass? Yes
Fixed Tickets
License MIT
Doc PR
Dependency Changes "babel-plugin-transform-numeric-separator" moves from stage 1 to stage 2

@hzoo
Copy link
Copy Markdown
Member

hzoo commented Aug 8, 2017

Will also need to change the index.js file in both*

Moving up stages shouldn't be breaking because stage-0 includes stage-1 etc

something like 5492fe1

@hzoo hzoo added the PR: Spec Compliance 👓 A type of pull request used for our changelog categories label Aug 8, 2017
@hzoo hzoo mentioned this pull request Aug 8, 2017
10 tasks
@rwaldron
Copy link
Copy Markdown
Contributor Author

Will also need to change the index.js file in both*

lol, I'm embarrassed to even try to explain why I think I missed/forgot this ;) Thanks for being patient with me :D

Moving up stages shouldn't be breaking because stage-0 includes stage-1 etc

ok, got it!

@rwaldron rwaldron force-pushed the bump_numeric_separator_stage_2 branch from 69d5834 to 5249d01 Compare August 10, 2017 14:14
@hzoo hzoo merged commit 9c91e35 into babel:7.0 Aug 10, 2017
@hzoo
Copy link
Copy Markdown
Member

hzoo commented Aug 10, 2017

Cool thanks 😄

@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 6, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Spec Compliance 👓 A type of pull request used for our changelog categories Priority: High

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants