Add feature to pass array of deps to a helper#6058
Closed
peey wants to merge 1 commit intobabel:masterfrom
Closed
Conversation
|
@peey, thanks for your PR! By analyzing the history of the files in this pull request, we identified @loganfsmyth, @hzoo and @existentialism to be potential reviewers. |
Member
|
Can you update this post #5706? We could support it using |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, this is a simple way to allow for interdependent helpers (see #6030 for explanation). I could not wait on #5706 since the upcoming decorator transform uses this feature, and neither could I hack on 5706 myself.
I couldn't figure a way to add tests for this (since you'd have to introduce new helpers in
helpers.jsjust for the sake of this PR) but I've added some new helpers in a wip branch and it works with those.I suppose this could be repealed after we have an ability to simply import helpers when 5706 makes them modular.