Add optionality to catch bindings by MarckK · Pull Request #5956 · babel/babel

MarckK · 2017-07-16T15:16:31Z

Q	A
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?	yes
Deprecations?
Spec Compliancy?
Tests Added/Pass?
Fixed Tickets
License	MIT
Doc PR
Dependency Changes

This implements the optional catch binding proposal (babel/proposals #7).

jridgewell

We'll also need:

Change to babel-types to make param optional.
Change to babel-generator to output a param-less clause.
A transform that generates a unique Identifier if one is not present.
Tests for the above

packages/babel-plugin-transform-optional-catch-binding/src/index.js

packages/babel-plugin-transform-d-opt-catch-binding/.npmignore

packages/babel-plugin-transform-optional-catch-binding/README.md

packages/babel-plugin-transform-optional-catch-binding/src/index.js

hzoo · 2017-07-23T13:25:09Z

Looks good! I would add a change to babel-generator to output a param-less clause - basically when it becomes part of the language we'll want to print it out as is instead transform it so babel should be able to handle that.

Also I would add an exec test to just test that it runs correctly.

packages/babel-plugin-transform-optional-catch-binding/src/index.js

packages/babel-core/package.json

packages/babel-plugin-transform-optional-catch-binding/README.md

.../babel-plugin-transform-optional-catch-binding/test/fixtures/optional-catch-bindings/exec.js

hzoo · 2017-07-24T18:30:40Z

looks good so far, basically done?

We also want to do

update other babylon deps to latest version
Change to babel-generator to output a param-less clause. https://github.com/babel/babel/blob/7.0/packages/babel-generator/src/generators/statements.js#L171

https://github.com/babel/babel/wiki/Adding-a-new-Proposal-to-Babel

Can use also https://github.com/babel/babel/pull/5813/files as a reference to files/structure/etc

jridgewell

Just have @hzoo's nits.

jridgewell

Oh, sorry, still need babel-generator updates.

existentialism

@MarckK nice work!

packages/babel-plugin-transform-optional-catch-binding/src/index.js

hzoo

Nice work!! Great example of a good PR that implements the parser/transform/types/generator/docs change that is required for a proposal to be in Babel. I think the only thing we didn't do is add it to a stage preset since it hasn't even been presented yet 😅

Add optionality to catch bindings

72b6c94

jridgewell requested changes Jul 16, 2017

View reviewed changes

bakkot mentioned this pull request Jul 17, 2017

Optional Catch Binding (Stage 4) babel/proposals#7

Open

2 tasks

loganfsmyth mentioned this pull request Jul 17, 2017

Export default unnamed declaration #5952

Closed

hzoo added PR: New Feature 🚀 A type of pull request used for our changelog categories es-proposal labels Jul 18, 2017

bakkot reviewed Jul 19, 2017

View reviewed changes

packages/babel-plugin-transform-optional-catch-binding/src/index.js Outdated Show resolved Hide resolved

existentialism reviewed Jul 19, 2017

View reviewed changes

packages/babel-plugin-transform-d-opt-catch-binding/.npmignore Outdated Show resolved Hide resolved

existentialism reviewed Jul 19, 2017

View reviewed changes

packages/babel-plugin-transform-optional-catch-binding/README.md Outdated Show resolved Hide resolved

MarckK force-pushed the optional-catch-binding branch from 25e8cfe to adcd680 Compare July 20, 2017 15:41

babel-plugin-transform-optional-catch-binding

efba0af

MarckK force-pushed the optional-catch-binding branch from adcd680 to efba0af Compare July 21, 2017 09:35

Fix babel-types to make param optional for CatchClause

47988bf

bakkot reviewed Jul 21, 2017

View reviewed changes

packages/babel-plugin-transform-optional-catch-binding/src/index.js Outdated Show resolved Hide resolved

jridgewell reviewed Jul 21, 2017

View reviewed changes

packages/babel-plugin-transform-optional-catch-binding/src/index.js Outdated Show resolved Hide resolved

Change how param transformed

1e4de40

MarckK force-pushed the optional-catch-binding branch from bb6d1cc to 1e4de40 Compare July 23, 2017 12:19

jridgewell reviewed Jul 23, 2017

View reviewed changes

packages/babel-plugin-transform-optional-catch-binding/src/index.js Outdated Show resolved Hide resolved

Fix check for path.node.param, fix tests, add exec test

243521c

hzoo reviewed Jul 24, 2017

View reviewed changes

packages/babel-core/package.json Show resolved Hide resolved

hzoo reviewed Jul 24, 2017

View reviewed changes

packages/babel-plugin-transform-optional-catch-binding/README.md Outdated Show resolved Hide resolved

hzoo reviewed Jul 24, 2017

View reviewed changes

.../babel-plugin-transform-optional-catch-binding/test/fixtures/optional-catch-bindings/exec.js Show resolved Hide resolved

jridgewell approved these changes Jul 24, 2017

View reviewed changes

jridgewell requested changes Jul 24, 2017

View reviewed changes

update Babylon, edit readme

08dc56b

existentialism approved these changes Jul 25, 2017

View reviewed changes

babel-generator to output param-less catch clause

80f532d

MarckK force-pushed the optional-catch-binding branch from 4f0913b to 80f532d Compare July 25, 2017 14:06

jridgewell approved these changes Jul 25, 2017

View reviewed changes

packages/babel-plugin-transform-optional-catch-binding/src/index.js Outdated Show resolved Hide resolved

hzoo approved these changes Jul 25, 2017

View reviewed changes

single check if catch clause param present

2d57316

existentialism added this to the Babel 7 milestone Jul 25, 2017

existentialism merged commit 9fc910d into babel:7.0 Jul 25, 2017

MarckK deleted the optional-catch-binding branch July 25, 2017 15:25

hzoo added Spec: Optional Catch Binding and removed area: tc39 proposal labels Oct 5, 2017

lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 6, 2019

lock bot locked as resolved and limited conversation to collaborators Oct 6, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add optionality to catch bindings#5956

Add optionality to catch bindings#5956
existentialism merged 8 commits intobabel:7.0from
MarckK:optional-catch-binding

MarckK commented Jul 16, 2017 •

edited

Loading

Uh oh!

jridgewell left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hzoo commented Jul 23, 2017

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hzoo commented Jul 24, 2017 •

edited

Loading

Uh oh!

jridgewell left a comment

Uh oh!

jridgewell left a comment

Uh oh!

existentialism left a comment

Uh oh!

Uh oh!

hzoo left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

MarckK commented Jul 16, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jridgewell left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hzoo commented Jul 23, 2017

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hzoo commented Jul 24, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jridgewell left a comment

Choose a reason for hiding this comment

Uh oh!

jridgewell left a comment

Choose a reason for hiding this comment

Uh oh!

existentialism left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

hzoo left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

MarckK commented Jul 16, 2017 •

edited

Loading

hzoo commented Jul 24, 2017 •

edited

Loading