Skip to content

Attempt to fix tests on plugin ordering + cleanup#5911

Closed
sarupbanskota wants to merge 80 commits intobabel:plugin-orderingfrom
sarupbanskota:fix/plugin-ordering-failing-tests
Closed

Attempt to fix tests on plugin ordering + cleanup#5911
sarupbanskota wants to merge 80 commits intobabel:plugin-orderingfrom
sarupbanskota:fix/plugin-ordering-failing-tests

Conversation

@sarupbanskota
Copy link
Copy Markdown
Contributor

@sarupbanskota sarupbanskota commented Jul 3, 2017 •
edited
Loading

In this PR

  • I've merged 7.0 into plugin-ordering, and fixed several conflicts
  • you'll find last few commits to be most relevant
  • if you change base to 7.0 instead, you can check out just the relevant sections
  • there are some flow errors, not worrying about it right now

Qantas94Heavy and others added 30 commits May 16, 2017 22:39
@Qantas94Heavy
Fix optimisation of shadowed rest parameters
0667160 
The arguments of a function would be unnecessarily copied if there was
a nested function that had a parameter with the same identifier as the
rest parameter for the outer function. This checks the scope of the
parameter is correct before deoptimising.

Fixes: #5656
Refs: #2091
@xtuc @jridgewell
feat: optional chaing
00f58b9
@xtuc @jridgewell
feat: cleanup
72259ca
@xtuc @jridgewell
refactor: improved transformation logic
64ff5a0
@xtuc @jridgewell
fix: use undefined instead of null
ed15443
@xtuc @jridgewell
feat: optional chaining with function call
6bd3bf4
@xtuc @jridgewell
feat: WIP assignements
cc6959e
@xtuc @jridgewell
wip
3faca62
@xtuc @jridgewell
refactor: change undefined to void 0
a9d8040
@xtuc @jridgewell
fix: typo
98487b5
@xtuc @jridgewell
refactor: use WeakSet to keep track of transformed nodes
750b03a
@jridgewell
Implement Null Propagation Operator
3fae121
@jridgewell
Use a better nested syntax
2a49689 
This way, it quickly returns from the conditions. The first nil will
now exit, instead of checking every nil.

This also allows conditionalChaining inside a container to still
operate the container.
@jridgewell
Split syntax and transform into two plugins
30ee871
@jridgewell
Simplify NewExpression|CallExpression visitor
5fe4803
@jridgewell
Print optional chain operator
85b6b4b
@jridgewell
Refactor
acdd363
@jridgewell
Reduce context memoization when possible
9ce797d
@jridgewell
Add optional to MemberExpression
b048bff
@jridgewell
Add exec tests
899634d
@jridgewell
Readme
0e5f597
@jridgewell
Lint
1f22ac3
@jridgewell
Test not-top-level optional chaining
ef87acc
@jridgewell
Delete unnecessary check
a62cb92
@jridgewell
Consider any unary expression
6cc2f5d
@jridgewell
Use nil
faa6c9f
@jridgewell
PR comments
d92309f
@jridgewell
Test Update and Unary expressions
54d9732
@jridgewell
Optional call expressions short circuit later member expressions
9e91ac5
@jridgewell
Simplify transform
462825b 
This also makes the output use less comparisons for `foo?.()?.bar`
cases. 😁
loganfsmyth and others added 16 commits June 26, 2017 15:49
@loganfsmyth
Revert "TEMP: Debugging unexpected test failures."
12e3911 
This reverts commit 1fb3d5b.
@loganfsmyth
Revert "TEMP: Another quick test"
95b3c8a 
This reverts commit 0005b9e.
@loganfsmyth
Force color output in test runs to ensure consistent behavior in Travis.
892377a
@loganfsmyth
Force color output in test runs to ensure consistent behavior in Trav…
b3183b1 
…is (Take 2)
@jridgewell
Add to stage-1 preset
f363ec6
@hzoo
Merge pull request #5813 from jridgewell/pr/5786
89d8f70 
Optional Chaining Operator (Stage 1)
@existentialism
Add prettier
93cc22d
@existentialism
Run prettier
e4b35f6
@hzoo
Merge pull request #5412 from babel/prettify
4e50b2d 
Use prettier
@hzoo
update babylon
a4080dc
@hzoo
remove unused dependencies
9a75916
@hzoo
Merge pull request #5889 from babel/update-babylon
ed0de70 
Update babylon
@joshwnj @hzoo
Fix 5768 (to 7.0 branch) (#5891)
bc29145
@danez @existentialism
Remove whitespace generation (#5833)
b3372a5 
* Remove whitespace generation and rely on default printing

Changes to printing:
* Add newline after last empty SwitchCase
* Add newlines around block comments if they are non-flow comments or contain newlines

* Fix a few more fixtures
@existentialism
Fix some unneeded semis in test fixtures (#5892)
58ec149
@sarupbanskota
Do null check for before/after
f44f4aa
@mention-bot
Copy link
Copy Markdown

mention-bot commented Jul 3, 2017

@sarupbanskota, thanks for your PR! By analyzing the history of the files in this pull request, we identified @loganfsmyth, @existentialism and @hzoo to be potential reviewers.

@sarupbanskota sarupbanskota changed the base branch from 7.0 to plugin-ordering July 3, 2017 23:58
@sarupbanskota sarupbanskota changed the title Attempt to fix tests on plugin ordering + cleanup [WIP] Attempt to fix tests on plugin ordering + cleanup Jul 4, 2017
@sarupbanskota sarupbanskota mentioned this pull request Jul 4, 2017
Closed
@sarupbanskota sarupbanskota changed the base branch from plugin-ordering to 7.0 July 6, 2017 18:24
@sarupbanskota sarupbanskota changed the base branch from 7.0 to plugin-ordering July 6, 2017 18:24
@sarupbanskota sarupbanskota changed the title [WIP] Attempt to fix tests on plugin ordering + cleanup Attempt to fix tests on plugin ordering + cleanup Jul 6, 2017
@sarupbanskota sarupbanskota mentioned this pull request Jul 6, 2017
Closed
7 tasks
@nicolo-ribaudo nicolo-ribaudo deleted the branch babel:plugin-ordering July 20, 2023 13:42
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 20, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

outdated A closed issue/PR that is archived due to age. Recommended to make a new issue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.