babel-types: Add TypeScript definitions · Pull Request #5856 · babel/babel

ghost · 2017-06-13T21:47:49Z

Q	A
Patch: Bug Fix?	no
Major: Breaking Change?	Yes in a few places, but only where it was wrong before.
Minor: New Feature?	yes
Deprecations?	no
Spec Compliancy?	yes
Tests Added/Pass?	n/a (see below)
Fixed Tickets
License	MIT
Doc PR
Dependency Changes

Companion to babel/babylon#523. This adds definitions for all of the TypeScript nodes.
I tested this by recursively validating TypeScript trees parsed from DefinitelyTyped. That script also tests the TS plugin, so I'll wait to include the script in the PR that adds the plugin.

CC @JamesHenry @soda0289 This defines the spec for TypeScript nodes, and duplicates the information found in types.js in babel/babylon#523.

jridgewell · 2017-06-14T00:51:52Z

packages/babel-types/src/definitions/core.js

+  },
+};
+
 defineType("CallExpression", {


This now requires a builder property.

jridgewell · 2017-06-14T00:52:44Z

packages/babel-types/src/definitions/core.js

@@ -279,41 +302,44 @@ defineType("FunctionExpression", {
  inherits: "FunctionDeclaration",
  aliases: ["Scopable", "Function", "BlockParent", "FunctionParent", "Expression", "Pureish"],
  fields: {


Is this necessary? It already inherits.

It doesn't look like "inherits" merges things? opts.fields = opts.fields || inherits.fields || {};

But all the fields are the same, right?

A FunctionExpression can't have declare. id and body are the same but I don't think it would be worth extracting those out separately.

jridgewell · 2017-06-14T00:54:02Z

packages/babel-types/src/definitions/core.js

@@ -441,22 +467,18 @@ defineType("MemberExpression", {
 });

 defineType("NewExpression", {


This now requires a builder property.

jridgewell · 2017-06-14T00:54:51Z

packages/babel-types/src/definitions/core.js

      validate: (function () {
-        const normal = assertNodeType("Expression");
-        const computed = assertNodeType("Identifier", "StringLiteral", "NumericLiteral");
+        const normal = assertNodeType("Identifier", "StringLiteral", "NumericLiteral");


Shit, did I get these backwards? 😳

jridgewell · 2017-06-14T00:56:09Z

packages/babel-types/src/definitions/core.js

@@ -558,14 +575,12 @@ defineType("ObjectProperty", {

 defineType("RestElement", {


This now requires a builder property.

jridgewell · 2017-06-14T00:56:48Z

packages/babel-types/src/definitions/es2015.js

 } from "./index";
+import { functionCommon, patternLikeCommon } from "./core";

 defineType("AssignmentPattern", {


This now requires a builder property.

jridgewell · 2017-06-14T00:56:54Z

packages/babel-types/src/definitions/es2015.js

@@ -26,10 +28,11 @@ defineType("AssignmentPattern", {

 defineType("ArrayPattern", {


This now requires a builder property.

jridgewell · 2017-06-14T00:57:42Z

packages/babel-types/src/definitions/es2015.js

-    params: {
-      validate: chain(assertValueType("array"), assertEach(assertNodeType("LVal"))),
+    // Unlike other functions, arrow functions are never generators.
+    ...(() => { const x = functionCommon; delete x.generator; return x; })(),


This is icky.

There is a proposal for arrow function generators at Stage 1 (not implemented) https://github.com/tc39/proposals

JamesHenry · 2017-06-14T08:07:04Z

Thanks for sharing @Andy-MS 👍 I'll use this to build out a separate, shared test suite now that we are much closer to convergence

ghost · 2017-06-14T14:03:23Z

Hi @JamesHenry, I did write a validator that you can find in preview at https://github.com/andy-ms/babel/blob/typescript/packages/babel-plugin-transform-typescript/test/astUtils.js .

codecov · 2017-06-14T22:25:01Z

Codecov Report

Merging #5856 into 7.0 will increase coverage by 0.08%.
The diff coverage is 98.83%.

@@            Coverage Diff             @@
##              7.0    #5856      +/-   ##
==========================================
+ Coverage   85.25%   85.34%   +0.08%     
==========================================
  Files         284      286       +2     
  Lines        9963    10030      +67     
  Branches     2781     2781              
==========================================
+ Hits         8494     8560      +66     
  Misses        969      969              
- Partials      500      501       +1

Impacted Files	Coverage Δ
packages/babel-types/src/definitions/flow.js	`100% <ø> (ø)`	⬆️
packages/babel-types/src/definitions/typescript.js	`100% <100%> (ø)`
packages/babel-types/src/definitions/core.js	`98.61% <100%> (+0.08%)`	⬆️
...ckages/babel-types/src/definitions/tsFlowCommon.js	`100% <100%> (ø)`
packages/babel-types/src/definitions/es2015.js	`96.96% <88.88%> (+0.3%)`	⬆️
...bel-plugin-transform-es2015-parameters/src/rest.js	`98.14% <0%> (-1.86%)`	⬇️
...bel-plugin-transform-es2015-classes/src/vanilla.js	`91.06% <0%> (+0.42%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5387d9f...3b4f31a. Read the comment docs.

Jessidhia · 2017-06-28T08:57:08Z

packages/babel-types/src/definitions/typescript.js

+defineType("TSDeclareMethod", {
+  visitor: ["decorators", "key", "typeParameters", "params", "returnType"],
+  fields: classMethodOrDeclareMethodCommon,
+});


Are these for overload declarations, or for things that have the declare keyword?

Could be either. It's any method with no body.

declare class C1 { // ClassDeclaration with declare: true m(): void; // TSDeclareMethod } class C2 { m(x: number): number; // TSDeclareMethod m(x: string): string; // TSDeclareMethod m(x: any) { return x; } // ClassMethod }

hzoo · 2017-07-12T20:19:55Z

packages/babel-types/src/definitions/core.js

 });

+export const functionCommon = {
+  params: {


Looks like generator got removed?

generator: { default: false, validate: assertValueType("boolean"), }

jridgewell · 2017-07-14T02:53:10Z

packages/babel-types/src/definitions/core.js


-defineType("CallExpression", {
-  visitor: ["callee", "arguments"],
+const callOrNew = {


Could we just have NewExpression inherit from CallExpression?

jridgewell · 2017-07-14T03:05:31Z

packages/babel-types/src/definitions/core.js

+  },
+  id: {
+    validate: assertNodeType("Identifier"),
+    optional: true, // May be null for `export default function`


Who's bright idea was this?!

export default function () {} should be named *default*, which you can't really represent as a valid Identifier :)

Moving this to babel/babylon#630.

jridgewell · 2017-07-14T03:18:40Z

packages/babel-types/src/definitions/es2015.js

-        assertEach(assertNodeType("LVal")),
-      ),
+    ...functionCommon,
+    expression: {


Instead of adding this, we should be removing it from babylon.

jridgewell · 2017-07-14T03:21:25Z

packages/babel-types/src/definitions/es2015.js

+    },
+    id: {
+      validate: assertNodeType("Identifier"),
+      optional: true, // Missing if this is the child of an ExportDefaultDeclaration.


Same reason as function. They're both special-cased in the spec to allow omitting the name specifically in this case.

hzoo

awesome work again andy, sorry for the wait

babel-types: Add TypeScript definitions

bd69873

jridgewell reviewed Jun 14, 2017

View reviewed changes

hzoo added the PR: New Feature 🚀 A type of pull request used for our changelog categories label Jun 14, 2017

Andy Hanson added 2 commits June 14, 2017 15:17

Add missing builders

545bb74

Allow arrow function to have "generator"

da2bc31

Replace link to resolved issue with comment

3b4f31a

Jessidhia reviewed Jun 28, 2017

View reviewed changes

Merge branch '7.0' into ts-definitions

cab6e7c

This was referenced Jun 28, 2017

babel-generator: Add TypeScript support #5896

Merged

Add babel-plugin-syntax-typescript, babel-plugin-transform-typescript, and babel-preset-typescript #5899

Merged

hzoo added the area: typescript label Jun 28, 2017

hzoo mentioned this pull request Jun 29, 2017

Typescript Plugin babel/babylon#320

Closed

5 tasks

hzoo reviewed Jul 12, 2017

View reviewed changes

Re-add 'generator' to functionCommon

03b8b82

jridgewell approved these changes Jul 14, 2017

View reviewed changes

jridgewell mentioned this pull request Jul 15, 2017

Export default unnamed declaration #5952

Closed

hzoo approved these changes Jul 25, 2017

View reviewed changes

hzoo merged commit 248743e into babel:7.0 Jul 25, 2017

ghost deleted the ts-definitions branch July 26, 2017 17:46

ghost mentioned this pull request Jul 26, 2017

babel-types: Have NewExpression inherit from CallExpression #6019

Merged

JLHwung mentioned this pull request Jul 24, 2019

Add static to class property builder #10248

Merged

lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 6, 2019

lock bot locked as resolved and limited conversation to collaborators Oct 6, 2019

		@@ -441,22 +467,18 @@ defineType("MemberExpression", {
		});

		defineType("NewExpression", {

		@@ -558,14 +575,12 @@ defineType("ObjectProperty", {

		defineType("RestElement", {

		@@ -26,10 +28,11 @@ defineType("AssignmentPattern", {

		defineType("ArrayPattern", {

Uh oh!

Conversation

ghost commented Jun 13, 2017 • edited by ghost Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

JamesHenry commented Jun 14, 2017

Uh oh!

ghost commented Jun 14, 2017

Uh oh!

codecov bot commented Jun 14, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jridgewell Jul 14, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hzoo left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ghost commented Jun 13, 2017 •

edited by ghost

Loading

codecov bot commented Jun 14, 2017 •

edited

Loading

jridgewell Jul 14, 2017 •

edited

Loading