I'm guessing the next step will be to name the unnamed core packages?

I wrote a little script:

const fileSystem = require('fs');

const returnFilesWithin = (path) => {
  return fileSystem.readdirSync(path);
}

returnFilesWithin('packages').forEach(package => {
  if (fileSystem.lstatSync(`packages/${package}`).isDirectory()) {
    fileSystem.readFile(`packages/${package}/package.json`, 'utf8', (err, content) => {
      const packageOptions = JSON.parse(content);
      console.log(packageOptions.name);
    });
  }
})

and that printed https://gist.github.com/sarupbanskota/4bf6627eb1501be1b8c14be406164aa4. No empty lines 🤔 What am I missing?

learned from @hzoo that it needs to be within the visitor
e.g in here: https://github.com/babel/babel/blob/7.0/packages/babel-plugin-transform-es2015-computed-properties/src/index.js#L87

visitor: {
  name: "transform-es2015-computed-properties"
  ...
}

i'll think of ways to do it for all core plugin packages

update:

name: "transform-es2015-computed-properties",
visitor: {
  ...
}

Why does the visitor have a name and not the plugin?

yeah that's incorrect - check http://astexplorer.net/ for an example

Just documenting thought process here. Based on two | examples, we wanna do the following:

1. Iterate over all core babel plugin packages. These are packages within packages/ that match /^babel-plugin/
2. Store the name as whatever follows babel-plugin-*
3. codemod the plugin with codemod --require babel-register --plugin plugin.js packages/${package}/src/index.js
4. plugin.js effectively does the following:

body:
  type: "ExportDefaultDeclaration"
    declaration: 
      type: "FunctionDeclaration"
        body: 
          type: "BlockStatement"
            body:
              type: "ReturnStatement"
                argument: 
                  type: "ObjectExpression"
                    properties: [Array 1]  ← we wanna inject `name` as another prop here

Instead of manually updating filenames on the core packages, I'm doing this programmatically to teach myself to play with the various babel packages available, but as @nathanhammond and @hzoo discussed on Slack, we could use this logic to build a tiny plugin upgrade service or similar

Not every plugin has to be formatted in that way but hopefully most are? I would just check for visitor and add the property

https://github.com/babel/kneden/blob/master/src/index.js#L19
https://github.com/tleunen/babel-plugin-module-resolver/blob/master/src/index.js#L25
https://github.com/lodash/babel-plugin-lodash/blob/master/src/index.js#L141

Still don't think the names should be used as capabilities, but if this somehow will give us better error messages ok.

Ah shoot, I made quite a bit of progress and only noticed your comment now @hzoo.

Anyway, here's what I have so far:
Based on the original exploration, I have a plugin that injects a name property with a dummy name atm: https://github.com/sarupbanskota/babel-plugin-add-name-to-plugin/blob/master/src/index.js

export default function({ types: t }) {

  return {
    visitor: {
      ExportDefaultDeclaration(path) {
        let pluginReturn;
        try {
          pluginReturn = path          // "ExportDefaultDeclaration"
            .get('declaration')        // "FunctionDeclaration"
            .get('body')               // "BlockStatement"
            .get('body.0')             // "ReturnStatement"
            .get('argument')           // "ObjectExpression"
            .get('properties.0');      // "ObjectMethod"
        } catch(e) {
          console.log(e);
        } finally {
          const nameKey = t.identifier("name");
          const nameValue = t.stringLiteral("pluginName");
          pluginReturn.insertBefore(t.objectProperty(nameKey, nameValue));
        }
      }
    }
  }
}

Other than the fact that it may not work for every case, please let me know if you see anything if I'm totally in the wrong direction with the way I've written it!

What's pending for me:

• Make plugin name injection work for different kinds of files (maybe consider @hzoo's visitor comment)
• Find a way to pass plugin package name into the plugin file for injection
• Get the plugin out as an npm package
• Don't inject name if it's already present

Just copying over my message from Slack:

I wrote this plugin https://github.com/babel/babel/pull/5842/files#diff-9db534602dc20174af286fa13dba8b05

and ran this code to run it through babel's core packages https://github.com/babel/babel/pull/5842/files#diff-46ab14e9c7ab9cf574a7e8f116b8d6b0

1. Does the plugin seem written well? what would you improve?
2. In some cases, e,g https://github.com/babel/babel/pull/5842/files#diff-2ba358dbf7b25653c724e1acd475a922 seems like both ObjectExpression and ExportDefaultDeclaration got triggered, and there were two modifications to the same file, despite adding a check for it. One way to remove it would be writing 2 plugins, is there a better way?

I figured out the problem, and will send an update tonight

I'm triaging old PR on Babel. Since this has been sitting for ages, I'm going to close it. If you want to rebase this to just add plugin names to our packages, feel free to open a new PR.