Skip to content

⬆️ Alpha 12#5808

Merged
hzoo merged 2 commits into7.0from
alpha-11
Jun 1, 2017
Merged

⬆️ Alpha 12#5808
hzoo merged 2 commits into7.0from
alpha-11

Conversation

@hzoo
Copy link
Copy Markdown
Member

@hzoo hzoo commented Jun 1, 2017

(node:79847) DeprecationWarning: Passing lineNumber and colNumber is deprecated to babel-code-frame. Please use codeFrameColumns 😅

@hzoo hzoo added the PR: Internal 🏠 A type of pull request used for our changelog categories label Jun 1, 2017
@hzoo hzoo changed the title Alpha 11 ⬆️ Alpha 12 Jun 1, 2017
@hzoo hzoo mentioned this pull request Jun 1, 2017
Merged
@codecov
Copy link
Copy Markdown

codecov bot commented Jun 1, 2017 •
edited
Loading

Codecov Report

Merging #5808 into 7.0 will decrease coverage by 0.05%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##              7.0    #5808      +/-   ##
==========================================
- Coverage   84.91%   84.86%   -0.06%     
==========================================
  Files         284      284              
  Lines        9928     9928              
  Branches     2788     2787       -1     
==========================================
- Hits         8430     8425       -5     
- Misses        988      990       +2     
- Partials      510      513       +3
Impacted Files Coverage Δ
packages/babel-traverse/src/path/replacement.js 82.45% <0%> (-0.73%) ⬇️
...ckages/babel-core/src/transformation/file/index.js 87.2% <100%> (+0.05%) ⬆️
packages/babel-code-frame/src/index.js 88.34% <0%> (-5.83%) ⬇️
packages/babel-traverse/src/visitors.js 85.71% <0%> (-0.96%) ⬇️
packages/babel-traverse/src/path/context.js 86.2% <0%> (ø) ⬆️
...bel-plugin-transform-es2015-classes/src/vanilla.js 90.98% <0%> (+0.34%) ⬆️
packages/babel-traverse/src/path/modification.js 73.07% <0%> (+0.96%) ⬆️
packages/babel-helper-call-delegate/src/index.js 68% <0%> (+4%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e739f9...ec9670a. Read the comment docs.

@hzoo hzoo merged commit 272209a into 7.0 Jun 1, 2017
SimenB
SimenB reviewed Jun 1, 2017
View reviewed changes
packages/babel-core/src/transformation/file/index.js
const location = {
start: {
line: loc.line,
column: loc.column + 1,
Copy link
Copy Markdown
Contributor

@SimenB SimenB Jun 1, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sucks... Is the +1 expected?

Copy link
Copy Markdown
Member Author

@hzoo hzoo Jun 1, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh? in our code it was +1 already? I just copied it over

Copy link
Copy Markdown
Contributor

@SimenB SimenB Jun 1, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm thinking it should just work ™️ with existent AST loc objects. That was the point.

Copy link
Copy Markdown
Member Author

@hzoo hzoo Jun 1, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have any tests for it probably so I didn't really check, dono if you want to take a look

@SimenB SimenB mentioned this pull request Jun 2, 2017
Merged
@SimenB
Copy link
Copy Markdown
Contributor

SimenB commented Jun 2, 2017

still calls deprecated method: #5815

@hzoo hzoo deleted the alpha-11 branch June 9, 2017 19:29
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 6, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@SimenB SimenB SimenB left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Has PR outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Internal 🏠 A type of pull request used for our changelog categories

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hzoo @SimenB @babel-bot