Support for NumericLiteralSeparator, Stage 1 feature by rwaldron · Pull Request #5793 · babel/babel

rwaldron · 2017-05-30T19:01:18Z

~~Not ready for merge~~

Signed-off-by: Rick Waldron waldron.rick@gmail.com

Q	A
Patch: Bug Fix?	no
Major: Breaking Change?	no
Minor: New Feature?	yes
Deprecations?	no
Spec Compliancy?	yes
Tests Added/Pass?	yes
Fixed Tickets	Fixes #5783
License	MIT
Doc PR
Dependency Changes	yes

Adds support for Numeric Separator

mention-bot · 2017-05-30T19:01:20Z

@rwaldron, thanks for your PR! By analyzing the history of the files in this pull request, we identified @hzoo to be a potential reviewer.

codecov · 2017-05-30T23:39:44Z

Codecov Report

Merging #5793 into 7.0 will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##              7.0    #5793      +/-   ##
==========================================
+ Coverage   84.81%   84.82%   +0.01%     
==========================================
  Files         282      283       +1     
  Lines        9875     9877       +2     
  Branches     2777     2776       -1     
==========================================
+ Hits         8375     8378       +3     
+ Misses        991      990       -1     
  Partials      509      509

Impacted Files	Coverage Δ
packages/babel-preset-stage-1/src/index.js	`100% <ø> (ø)`	⬆️
...babel-plugin-syntax-numeric-separator/src/index.js	`100% <100%> (ø)`
packages/babel-cli/src/babel-node.js	`47.82% <0%> (+1.01%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3783429...47b676e. Read the comment docs.

rwaldron · 2017-05-30T23:43:37Z

@hzoo ready for an initial review!

xtuc · 2017-05-31T07:04:45Z

packages/babel-plugin-syntax-numeric-separator/README.md

@@ -0,0 +1,35 @@
+# babel-plugin-syntax-numeric-separator
+
+


To be consistent across package READMEs, could you add there a description:

# babel-plugin-syntax-numeric-separator > Transforms blablabla ## Installation [...]

We should maybe add this to the spec implementor documentation.

Yes, absolutely

xtuc · 2017-05-31T07:06:57Z

Nice job @rwaldron.

Do we want to backport that to 6.x?

hzoo · 2017-05-31T13:59:05Z

I'd like to not have to backport features, especially if it's a proposal?

rwaldron · 2017-05-31T14:13:31Z

@xtuc PR updated with amended commit; now includes: https://github.com/babel/babel/pull/5793/files#diff-921c1523bfcb64eefcc009dba96e1a3bR3

xtuc · 2017-05-31T14:15:11Z

Thanks @rwaldron. I just nit'ed cd8f6e0, you might want to squash it

rwaldron · 2017-05-31T14:18:07Z

packages/babel-plugin-syntax-numeric-separator/README.md

 # babel-plugin-syntax-numeric-separator

-Allow parsing of Numeric Literals (Decimal, Binary, Hex and Octal) that contain a _NumericLiteralSeparator_.
+> Allow parsing of Numeric Literals (Decimal, Binary, Hex and Octal) that contain a _NumericLiteralSeparator_.


I initially typed this as well (my transform plugin has >) but then looked at README.md files in other babel-plugin-syntax-* packages and the ones I looked at didn't have this, eg. https://github.com/babel/babel/tree/7.0/packages/babel-plugin-syntax-async-functions

I'll open an issue and do the work to update them all, if you'd like

Yes, that's correct. I can update them as well if you'd like.

Already done :D

hzoo · 2017-05-31T14:40:15Z

@rwaldron I assume the test failures are because it doesn't have your patch yet? I published 7.0.0-beta.12 yesterday so just have to update the 3 deps to use it - can just grep for "babylon":

https://github.com/babel/babylon/releases/tag/v7.0.0-beta.12

rwaldron · 2017-05-31T15:06:14Z

@hzoo all deps updated to 7.0.0-beta.12, and patch rebased

hzoo · 2017-05-31T15:24:13Z

packages/babel-plugin-transform-numeric-separator/README.md

+
+`boolean`, defaults to `false`.
+
+By default, this plugin will only remove the separators, printing Decimal, Binary, Hex and Octal number representations. Enabling this option will  convert them all to a Decimal value.


extra space here?

We do have a http://babeljs.io/docs/plugins/transform-es2015-literals/ to deal with this already so in the ideal case this plugin would defer to that for the transformation. Not sure how that fits but interesting in relation to #5735. I'm ok with doing this atm though.

This section has been removed.

commit cd8f6e0 Author: Sven SAULEAU <xtuc@users.noreply.github.com> Date: Wed May 31 16:14:15 2017 +0200 docs: update README [skip ci] commit cf013e3 Author: Rick Waldron <waldron.rick@gmail.com> Date: Tue May 30 14:51:20 2017 -0400 Support for NumericLiteralSeparator, Stage 1 feature Signed-off-by: Rick Waldron <waldron.rick@gmail.com> Signed-off-by: Rick Waldron <waldron.rick@gmail.com>

hzoo

looks good, I added a note about using a preset instead of an individual plugin

existentialism

👍

hzoo · 2017-05-31T19:32:42Z

Thanks a lot @rwaldron! (had to fix a failing issue but CI is being weird, it's 1d7d090)

rwaldron force-pushed the 5783 branch from 4b1a88b to f3d94f8 Compare May 30, 2017 23:39

xtuc reviewed May 31, 2017

View reviewed changes

xtuc added PR: New Feature 🚀 A type of pull request used for our changelog categories PR: Spec Compliance 👓 A type of pull request used for our changelog categories labels May 31, 2017

rwaldron force-pushed the 5783 branch from f3d94f8 to cf013e3 Compare May 31, 2017 14:12

rwaldron commented May 31, 2017

View reviewed changes

xtuc mentioned this pull request May 31, 2017

Publish syntax and transform doc for numeric separator babel/website#1257

Closed

rwaldron force-pushed the 5783 branch from cd8f6e0 to 34141e3 Compare May 31, 2017 14:28

rwaldron force-pushed the 5783 branch from 34141e3 to a301107 Compare May 31, 2017 15:04

hzoo reviewed May 31, 2017

View reviewed changes

rwaldron force-pushed the 5783 branch 2 times, most recently from 2f98ebc to 94f029f Compare May 31, 2017 16:39

rwaldron force-pushed the 5783 branch from 94f029f to 5e4b48a Compare May 31, 2017 16:42

add note about presets [skip ci]

47b676e

hzoo approved these changes May 31, 2017

View reviewed changes

existentialism approved these changes May 31, 2017

View reviewed changes

hzoo merged commit 5393a49 into babel:7.0 May 31, 2017

hzoo mentioned this pull request Jul 27, 2017

Numeric Separator (Stage 3) babel/proposals#20

Open

lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 6, 2019

lock bot locked as resolved and limited conversation to collaborators Oct 6, 2019


		`boolean`, defaults to `false`.

		By default, this plugin will only remove the separators, printing Decimal, Binary, Hex and Octal number representations. Enabling this option will convert them all to a Decimal value.

Uh oh!

Conversation

rwaldron commented May 30, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mention-bot commented May 30, 2017

Uh oh!

codecov bot commented May 30, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

rwaldron commented May 30, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

xtuc commented May 31, 2017

Uh oh!

hzoo commented May 31, 2017

Uh oh!

rwaldron commented May 31, 2017

Uh oh!

xtuc commented May 31, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hzoo commented May 31, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rwaldron commented May 31, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hzoo left a comment

Choose a reason for hiding this comment

Uh oh!

existentialism left a comment

Choose a reason for hiding this comment

Uh oh!

hzoo commented May 31, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

rwaldron commented May 30, 2017 •

edited

Loading

codecov bot commented May 30, 2017 •

edited

Loading

hzoo commented May 31, 2017 •

edited

Loading