Skip to content

Port flow object spread from #418 to 6.x#5653

Merged
hzoo merged 3 commits into6.xfrom
flow-object-spread-6-2
Apr 26, 2017
Merged

Port flow object spread from #418 to 6.x#5653
hzoo merged 3 commits into6.xfrom
flow-object-spread-6-2

Conversation

@sebmck
Copy link
Contributor

@sebmck sebmck commented Apr 20, 2017

Port flow object spread from #418 to 6.x

Q A
Patch: Bug Fix? new flow feature
Major: Breaking Change? no
Minor: New Feature? yes
Deprecations? no
Spec Compliancy? yes?
Tests Added/Pass? yes
Fixed Tickets Fixes #1, Fixes #2
License MIT
Doc PR
Dependency Changes

@mention-bot
Copy link

@kittens, thanks for your PR! By analyzing the history of the files in this pull request, we identified @loganfsmyth, @samwgoldman and @hzoo to be potential reviewers.

@codecov
Copy link

codecov bot commented Apr 20, 2017

Codecov Report

Merging #5653 into 6.x will increase coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##              6.x   #5653      +/-   ##
=========================================
+ Coverage   84.44%   84.5%   +0.05%     
=========================================
  Files         204     204              
  Lines        9599    9603       +4     
  Branches     2696    2696              
=========================================
+ Hits         8106    8115       +9     
+ Misses       1006    1001       -5     
  Partials      487     487
Impacted Files Coverage Δ
packages/babel-generator/src/generators/flow.js 97.85% <100%> (+0.02%) ⬆️
packages/babel-types/src/definitions/flow.js 100% <100%> (ø) ⬆️
packages/babel-traverse/src/visitors.js 85.71% <0%> (-0.96%) ⬇️
...bel-plugin-transform-es2015-classes/src/vanilla.js 90.59% <0%> (+0.42%) ⬆️
packages/babel-traverse/src/path/modification.js 74.75% <0%> (+0.97%) ⬆️
packages/babel-traverse/src/path/context.js 87.06% <0%> (+2.58%) ⬆️
packages/babel-helper-call-delegate/src/index.js 68% <0%> (+4%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1a7953...903f95f. Read the comment docs.

@rosskevin
Copy link

This change appears to be unreleased on the 6.x codeline so far. Any chance of cutting a 6.x maintenance release?

@hzoo hzoo added the PR: New Feature 🚀 A type of pull request used for our changelog categories label Jun 8, 2017
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 6, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

6.x: backport outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: New Feature 🚀 A type of pull request used for our changelog categories

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants