Conversation
|
@sheerun, thanks for your PR! By analyzing the history of the files in this pull request, we identified @hzoo, @zertosh and @existentialism to be potential reviewers. |
|
Hey @sheerun! It looks like one or more of your builds have failed. I've copied the relevant info below to save you some time. |
|
The test cases produced by this module for raw files (with extensions other than .js), don't seem to be passed to either visitor or manipulateOptions... not sure why. There's no point polishing this PR if I don't solve it. Any help appreciated. |
|
Thanks for the PR! babel-helper-fixtures/fixture-test-runner is intended for internal babel plugin use - not that we won't add it but I'm hesitant to add anything for what we aren't going to use ourselves. |
xtuc
left a comment
There was a problem hiding this comment.
This can be implemented by plugin author. We don't need the support for that in Babel itself.
|
I'm triaging old PR on Babel. Since this has been sitting for ages, I'm going to close it. If it's a conversation you want to continue, happy to do that though. |
This change allows for easier testing of babel plugins that operate on files of extensions other than
.js. In particular it allows for loading fixtures where actual file has extension different than.js, for example:actual.json,actual.css,actual.gql, etc.I've also added missing tests. There should be 100% backward compatibility