Skip to content

Added support for Windows for build and test.#4752

Closed
garyjN7 wants to merge 0 commit intobabel:masterfrom
garyjN7:master
Closed

Added support for Windows for build and test.#4752
garyjN7 wants to merge 0 commit intobabel:masterfrom
garyjN7:master

Conversation

@garyjN7
Copy link
Copy Markdown

@garyjN7 garyjN7 commented Oct 18, 2016

Q A
Bug fix? no
Breaking change? no
New feature? yes
Deprecations? no
Spec compliancy? no
Tests added/pass? no
Fixed tickets
License MIT
Doc PR reference to the documentation PR, if any

In order to allow Windows to run the various build and test commands, functionality moved from Makefile to package.json script so commands are no longer platform specific.

@codecov-io
Copy link
Copy Markdown

codecov-io commented Oct 19, 2016

Current coverage is 88.80% (diff: 100%)

No coverage report found for master at 4b3aaae.

Powered by Codecov. Last update 4b3aaae...9385dac

@danez danez added the PR: Internal 🏠 A type of pull request used for our changelog categories label Oct 21, 2016
@danez
Copy link
Copy Markdown
Member

danez commented Oct 21, 2016

Thanks for your contribution. This is really awesome and we definitely need better support for developing on windows.
Your commit changes a lot, also to critical parts like publishing, so please be patient with us while we decide how to proceed here. As we have a lot of commands and also chains of commands, it might even make sense to use a task runner like gulp, or similar, to make it less squeezed into package.json.

@garyjN7 garyjN7 closed this Nov 3, 2016
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 7, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Internal 🏠 A type of pull request used for our changelog categories

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants