Skip to content

[RFC] Make getBinding ignore labels; add Scope#getLabel #3649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kangax wants to merge 1 commit into from
Closed

[RFC] Make getBinding ignore labels; add Scope#getLabel #3649

kangax wants to merge 1 commit into from

Conversation

@kangax
Copy link
Member

@kangax kangax commented Aug 10, 2016 •
edited by danez
Loading

Fixes #3978

@sebmck
Copy link
Contributor

sebmck commented Aug 20, 2016

uid generator needs to be aware of these so collisions aren't generated.

@hzoo
Copy link
Member

hzoo commented Aug 20, 2016

@kittens ah good catch, would we create a hasLabel/hasLabelBinding and add it to the generateUid check in https://github.com/babel/babel/blob/master/packages/babel-traverse/src/scope/index.js#L220?

@hzoo hzoo mentioned this pull request Sep 10, 2016
Closed
@kangax kangax mentioned this pull request Oct 20, 2016
Merged
@kangax kangax closed this Oct 20, 2016
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 7, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

outdated A closed issue/PR that is archived due to age. Recommended to make a new issue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Labels shadow bindings (T6957)

3 participants

@kangax @sebmck @hzoo