Merged
Conversation
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/61196 |
|
commit: |
| @@ -0,0 +1 @@ | |||
| a::import() | |||
Member
There was a problem hiding this comment.
Can you add a test case for a::import.defer()?
liuxingbaoyu
approved these changes
Mar 17, 2026
6428b6c to
047d66b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR we forbid
super()afternewand the binary form function bind operator::.We also update the parentheses rule of the new callee in
@babel/generator. The new rule ensure optional chain and the the import expression are parenthesized when they are the callee of the new expression.We also disallow
NewExpression.calleebeing one ofSuper | Import | V8IntrinsicIdentifier, these productions are never valid and it is merely a side effect of inheritingCallExpressionin the types definition.