[Babel 8] Remove Import from the Expression alias#17867
Merged
JLHwung merged 6 commits intobabel:mainfrom Mar 13, 2026
Merged
Conversation
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/61170 |
| } satisfies ValidatorImpl, | ||
| { oneOfNodeTypes: ["Declaration"] as const }, | ||
| { | ||
| oneOfNodeTypes: [ |
Member
There was a problem hiding this comment.
What is the change here?
Contributor
Author
There was a problem hiding this comment.
This change is from the first commit.
Here we align with the current parser behaviour and disallow the following nodes (not a complete list) within the ExportNamedDeclaration:
ExportDeclarationImportDeclarationDeclareClass(formsDeclareExportDeclaration)DeclareFunction(formsDeclareExportDeclaration)
7138440 to
210311d
Compare
|
commit: |
nicolo-ribaudo
approved these changes
Mar 12, 2026
liuxingbaoyu
approved these changes
Mar 13, 2026
Contributor
Author
|
Docs PR is ready: babel/website#3188, PTAL. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to #14750, in this PR we remove
Importfrom theExpressionalias. In Babel 8 theImportnode will only be generated whencreateImportExpressionsisfalse, so this change should has less impact than theSuperone.This PR also refines the accepted node types in
ExportNamedDeclaration#declaration, allowsPrivateNameas the key of theOptionalMemberExpressionand introduces a few union types improvements.