refactor(parser): use AST definitions from babel/types#17853
Merged
nicolo-ribaudo merged 4 commits intobabel:mainfrom Mar 12, 2026
Merged
refactor(parser): use AST definitions from babel/types#17853nicolo-ribaudo merged 4 commits intobabel:mainfrom
nicolo-ribaudo merged 4 commits intobabel:mainfrom
Conversation
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/61157 |
|
commit: |
fef6de8 to
21f7ec1
Compare
Member
|
Could you rebase? :) |
21f7ec1 to
c581ae7
Compare
c581ae7 to
2027129
Compare
Contributor
Author
|
@liuxingbaoyu Thank you for rebasing. I removed the first two commits as they were included in #17852. |
nicolo-ribaudo
approved these changes
Mar 9, 2026
2027129 to
83f956a
Compare
83f956a to
105494a
Compare
liuxingbaoyu
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes commits from #17852, please review that PR first.
As a follow-up to #14783, in this PR we use
@babel/typesAST definitions to type@babel/parser. The@babel/parsertypes now only includes a few custom alias and ESTree AST shapes.I have disabled a few typing errors because in general
@babel/parseris more tolerant than the@babel/typesAST definitions due to the error recovery: It is possible that we assign nonexistent properties such that we can emit a recoverable error.There are also a few typing errors that points to incorrect parser behaviour. For the time being they are left as-is pending further investigation. So this PR is a refactor that aims for zero behaviour change.