Skip to content

Enable strictNullChecks for more packages#17828

Merged
nicolo-ribaudo merged 1 commit intobabel:mainfrom
liuxingbaoyu:null
Feb 27, 2026
Merged

Enable strictNullChecks for more packages#17828
nicolo-ribaudo merged 1 commit intobabel:mainfrom
liuxingbaoyu:null

Conversation

@liuxingbaoyu
Copy link
Copy Markdown
Member

Q                       A
Fixed Issues? Fixes #1, Fixes #2
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

To make review easier, I also disabled strictNullChecks for some packages.

@babel-bot
Copy link
Copy Markdown
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/61009

@liuxingbaoyu
Copy link
Copy Markdown
Member Author

strictFunctionTypes is correct, but it's very inconvenient.
It complains about all

{
	"NodeA|NodeB"(path: NodePath<NodeA | NodeB>) {
	} 
}

Users will encounter the same issue if they enable it. (Especially since TS6.0, this has become the default option.)
Do you have any ideas?

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Feb 24, 2026

Open in StackBlitz

commit: 53b9f0b

@nicolo-ribaudo nicolo-ribaudo merged commit 4fcbae7 into babel:main Feb 27, 2026
55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants