chore: Set allowUnreachableCode: false#17825
Merged
JLHwung merged 3 commits intobabel:mainfrom Mar 2, 2026
Merged
Conversation
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/61024 |
06dd881 to
857d370
Compare
JLHwung
approved these changes
Feb 24, 2026
liuxingbaoyu
commented
Feb 24, 2026
| "@typescript-eslint/prefer-nullish-coalescing": "off", | ||
| "@typescript-eslint/restrict-template-expressions": "off", | ||
| "@typescript-eslint/unbound-method": "off", | ||
| "prefer-rest-params": "off", |
Member
Author
There was a problem hiding this comment.
It is not disabled by ts-eslint.
Do you prefer to enable or disable it?
Contributor
There was a problem hiding this comment.
I don't have an opinion here. We can probably enable it except helper codes.
Member
Author
There was a problem hiding this comment.
I tried it, and it even complained that the parameter had already been used.
Let's disable it.
const newFn = function (this: unknown, path: NodePath) {
if (validator.call(path)) {
return fn.apply(this, arguments);
}
};|
commit: |
bd8b46a to
993d0c2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1, Fixes #2typescript-eslinthas disabled incompatible ESLint rules.no-unreachableis also included, so we enableallowUnreachableCode: falsein TypeScript, which is faster and more accurate.