Skip to content

Fix eslint package types#17822

Merged
nicolo-ribaudo merged 5 commits intobabel:mainfrom
liuxingbaoyu:publint
Mar 5, 2026
Merged

Fix eslint package types#17822
nicolo-ribaudo merged 5 commits intobabel:mainfrom
liuxingbaoyu:publint

Conversation

@liuxingbaoyu
Copy link
Copy Markdown
Member

Q                       A
Fixed Issues? Fixes #17821
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

@babel-bot
Copy link
Copy Markdown
Collaborator

babel-bot commented Feb 22, 2026

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/61102

@liuxingbaoyu liuxingbaoyu added area: eslint PR: Bug Fix (next major) 🐛 A type of pull request used for our changelog categories for next major release labels Feb 22, 2026
@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Feb 22, 2026

Open in StackBlitz

commit: 3477f0a

pack: "yarn",
});
for (const message of result.messages) {
if (message.type === "error") {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we output error to stderr if there is an error message?

@liuxingbaoyu
Copy link
Copy Markdown
Member Author

CI failures are expected. we need to remove the failed CIs or retain the compatible exports.

Copy link
Copy Markdown
Member

@nicolo-ribaudo nicolo-ribaudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you split this PR in two, so that we can enable linting after the release, and get it to pass?

@liuxingbaoyu
Copy link
Copy Markdown
Member Author

This check is currently checking the local repository. The CI failed because I removed https://github.com/babel/babel/pull/17822/changes#diff-6a9f4fa54adb5d9a89a76a35a55ccbb649bec45ee9a74b91d39d9d1d52415eacL127-L128.

@nicolo-ribaudo
Copy link
Copy Markdown
Member

Oh I see, so after merging it should pass?

@liuxingbaoyu
Copy link
Copy Markdown
Member Author

https://github.com/babel/babel/actions/runs/22495530191/job/65168898709?pr=17822
The newly added CI has been passed. :)
The failed CI was for older versions of Node.js. Since we removed the compatibility export (https://github.com/babel/babel/pull/17822/changes#diff-6a9f4fa54adb5d9a89a76a35a55ccbb649bec45ee9a74b91d39d9d1d52415eacL127-L128), we need to remove the CI or restore the compatibility export.

@nicolo-ribaudo
Copy link
Copy Markdown
Member

Could you take a look at the CI failures?

@liuxingbaoyu
Copy link
Copy Markdown
Member Author

Do you want to remove these failing CIs (nodejs < v17) or restore compatibility?
I'm hesitant.

@nicolo-ribaudo
Copy link
Copy Markdown
Member

I think @babel/runtime should preserve old Node.js compat, so that people can use Babel 8 when targeting old Node.js versions.

@liuxingbaoyu
Copy link
Copy Markdown
Member Author

I will revert that change.
Also, the current engines of babel-runtime are ^20.19.0 || >=22.12.0, do we need to change it?

@JLHwung
Copy link
Copy Markdown
Contributor

JLHwung commented Mar 4, 2026

I will revert that change. Also, the current engines of babel-runtime are ^20.19.0 || >=22.12.0, do we need to change it?

The current Babel-runtime 7 sets engines to >= 6.9.0. It seems that the engines setting here is unnecessary. The runtime is supposed to be run on any ES5 environments.

@nicolo-ribaudo
Copy link
Copy Markdown
Member

I'll merge this and prepare a PR for that.

@nicolo-ribaudo nicolo-ribaudo merged commit 9375740 into babel:main Mar 5, 2026
56 checks passed
@nicolo-ribaudo nicolo-ribaudo added the PR: Bug Fix 🐛 A type of pull request used for our changelog categories label Mar 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: eslint PR: Bug Fix 🐛 A type of pull request used for our changelog categories PR: Bug Fix (next major) 🐛 A type of pull request used for our changelog categories for next major release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[@babel/eslint-parser@8.0.0-rc.2] Broken Types

4 participants