Support ESLint v10 for babel-eslint-plugin#17811
Merged
nicolo-ribaudo merged 14 commits intobabel:mainfrom Feb 20, 2026
Merged
Conversation
\s* and [^{}]+? are interchangeable.
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/60964 |
|
commit: |
| !this.container || | ||
| // @ts-expect-error this.key should present in this.container | ||
| this.container[this.key] !== this.node | ||
| this.container?.[this.key] !== this.node |
Member
There was a problem hiding this comment.
I slightly prefer the old way of writing it because it's more readable.
I did a simple test locally, and it seems this option avoids reporting these kinds of errors.
https://typescript-eslint.io/rules/prefer-optional-chain/#requirenullish
liuxingbaoyu
approved these changes
Feb 19, 2026
| @@ -9,7 +9,7 @@ module.exports = { | |||
| create(ctx) { | |||
Member
There was a problem hiding this comment.
This rule seems to be no longer needed. :)
nicolo-ribaudo
approved these changes
Feb 20, 2026
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1, Fixes #2As a follow up to #17796, this PR adds support of ESLint v10 to babel-eslint-plugin. We inlined the
eslint-rule-composeras the library seems abandoned: The PR to address ESLint v9 deprecation has not yet been merged after 3 years: not-an-aardvark/eslint-rule-composer#13The inlined
eslint-rule-composeronly supports thefilterReportsmethod, we added support for ESLint v10 and fixed a polynomial back tracking bug.We also bumped other eslint plugins and tools.
Please carefully review the commit 4510ba4 due to theThis commit has been reverted.prefer-optional-chainrule.