Improve trailing comma comment handling#17782
Merged
JLHwung merged 6 commits intobabel:mainfrom Mar 4, 2026
Merged
Conversation
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/61098 |
JLHwung
commented
Feb 5, 2026
| "type": "TSStringKeyword", | ||
| "start":19,"end":25,"loc":{"start":{"line":2,"column":5,"index":19},"end":{"line":2,"column":11,"index":25}} | ||
| }, | ||
| "trailingComments": [ |
Contributor
Author
There was a problem hiding this comment.
The trailing comment is not attached to the TSPropertySignature because the node ends at the trailing comma. This is a bit odd compared to other elements with trailing comma, probably because the property signature also supports ; as a separator.
|
commit: |
21e4e69 to
7b7bb98
Compare
liuxingbaoyu
reviewed
Mar 4, 2026
| case "ImportDeclaration": | ||
| adjustInnerComments(node, node.specifiers, commentWS); | ||
| break; | ||
| case "TSEnumDeclaration": |
Member
There was a problem hiding this comment.
Why was TSEnumDeclaration removed?
I understand, the default branches are the same.
liuxingbaoyu
approved these changes
Mar 4, 2026
nicolo-ribaudo
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR we apply trailing comma comment adjustment on more nodes.