Skip to content

Improve core typings#17778

Merged
nicolo-ribaudo merged 2 commits intobabel:mainfrom
JLHwung:core-typing-feedback
Feb 13, 2026
Merged

Improve core typings#17778
nicolo-ribaudo merged 2 commits intobabel:mainfrom
JLHwung:core-typing-feedback

Conversation

@JLHwung
Copy link
Copy Markdown
Contributor

@JLHwung JLHwung commented Feb 4, 2026

Q                       A
Fixed Issues? Fixes #17777
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

/cc @sapphi-red Thank you very much for your feedback. More suggestions are welcome.

@JLHwung JLHwung added the PR: Polish (next major) 💅 A type of pull request used for our changelog categories for next major release label Feb 4, 2026
@babel-bot
Copy link
Copy Markdown
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/60861

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Feb 4, 2026

Open in StackBlitz

commit: e69762d

@nicolo-ribaudo nicolo-ribaudo merged commit fc53f3a into babel:main Feb 13, 2026
55 checks passed
@nicolo-ribaudo nicolo-ribaudo deleted the core-typing-feedback branch February 13, 2026 14:14
@sapphi-red
Copy link
Copy Markdown

Thank you! It seems these type assertions are still needed:

Now that I can easily assert the types, it's not a big deal, but I think it'd be nice if these assertions were not needed.

@nicolo-ribaudo nicolo-ribaudo added the PR: Polish 💅 A type of pull request used for our changelog categories label Mar 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg: core PR: Polish 💅 A type of pull request used for our changelog categories PR: Polish (next major) 💅 A type of pull request used for our changelog categories for next major release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Babel 8 RC types feedback

5 participants