Skip to content

Remove deprecated default export from @babel/code-frame#17772

Merged
JLHwung merged 3 commits intobabel:mainfrom
fisker:code-frame-default-export
Feb 4, 2026
Merged

Remove deprecated default export from @babel/code-frame#17772
JLHwung merged 3 commits intobabel:mainfrom
fisker:code-frame-default-export

Conversation

@fisker
Copy link
Copy Markdown
Contributor

@fisker fisker commented Feb 2, 2026

Q                       A
Fixed Issues? Fixes #17768
Patch: Bug Fix?
Major: Breaking Change? Yes
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link babel/website#3167
Any Dependency Changes?
License MIT

@babel-bot
Copy link
Copy Markdown
Collaborator

babel-bot commented Feb 2, 2026

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/60853

@fisker fisker marked this pull request as ready for review February 2, 2026 16:02
@JLHwung JLHwung added PR: Breaking Change 💥 A type of pull request used for our changelog categories for next major release PR: Needs Docs labels Feb 2, 2026
@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Feb 2, 2026

Open in StackBlitz

commit: 56e0c8e

Copy link
Copy Markdown
Member

@liuxingbaoyu liuxingbaoyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm surprised it's been 9 years.

Copy link
Copy Markdown
Member

@nicolo-ribaudo nicolo-ribaudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you -- I'll get RC.2 out this evening with this change.

@fisker
Copy link
Copy Markdown
Contributor Author

fisker commented Feb 3, 2026

We don't have plan for this #17316, right?

@nicolo-ribaudo
Copy link
Copy Markdown
Member

Not really. Out of curiosity, is it causing annoyance for Prettier?

@fisker
Copy link
Copy Markdown
Contributor Author

fisker commented Feb 3, 2026

No.

@fisker
Copy link
Copy Markdown
Contributor Author

fisker commented Feb 3, 2026

We have many parsers, they throws different errors anyway, we only need figure out the difference of line and column once when add new parser, don't care much.

@JLHwung JLHwung merged commit 8ddfe9c into babel:main Feb 4, 2026
55 checks passed
@JLHwung
Copy link
Copy Markdown
Contributor

JLHwung commented Feb 4, 2026

Docs PR is ready: babel/website#3167 PTAL.

This was referenced Feb 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: Breaking Change 💥 A type of pull request used for our changelog categories for next major release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove default export from @babel/code-frame

5 participants