chore: enable some ts-eslint rules #17592
Merged
+694
−681
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/60221 |
|
commit: |
nicolo-ribaudo
approved these changes
Nov 24, 2025
Member
nicolo-ribaudo
left a comment
There was a problem hiding this comment.
I would have slightly preferred the last commit to be in a separate PR.
The ban-types rule has been removed in ts-eslint v8.
This rule has been deprecated in favor of the perfectionist/sort-intersection-types and perfectionist/sort-union-types rules. Since we have installed perfectionist, removing this rule becomes no-op.
cf211ee to
68056df
Compare
Contributor
Author
OK, the last two commits are moved to #17606 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we enabled a few previously disabled ts-eslint rules.
array-typeconsistent-generic-constructorsconsistent-indexed-object-styleno-base-to-stringno-unsafe-declaration-mergingThe
no-base-to-stringrule detects a potential bug in the babel-standalone error message handling. This bug is also fixed in this PR.The following rules have been deprecated and replaced by third-party ts-eslint plugins. Before we install other plugins, they can be safely removed from our config:
ban-typessort-type-constituents