Harden variable declarator validations#17217
Merged
JLHwung merged 6 commits intobabel:mainfrom Apr 2, 2025
Merged
Conversation
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/59001 |
Member
|
Does this play well with TypeScript's |
Contributor
Author
Good catch. Currently no. The |
nicolo-ribaudo
approved these changes
Apr 1, 2025
Co-authored-by: Nicolò Ribaudo <hello@nicr.dev>
liuxingbaoyu
approved these changes
Apr 2, 2025
Contributor
Author
|
Docs PR is ready: babel/website#3075 PTAL |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is sprung off from #17163. Here we applied more constraints on variable declarator validations in Babel 8.