[Babel 8] Add several TS type parentheses rules#17131
Merged
nicolo-ribaudo merged 6 commits intobabel:mainfrom Feb 14, 2025
Merged
[Babel 8] Add several TS type parentheses rules#17131nicolo-ribaudo merged 6 commits intobabel:mainfrom
nicolo-ribaudo merged 6 commits intobabel:mainfrom
Conversation
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/58706 |
nicolo-ribaudo
approved these changes
Feb 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1, Fixes #2As a follow-up to #17125, this PR aims for adding parentheses rules for all TS productions from TSConditionalType descended all the way to non-array TS types. Here is a list in the order of their precedences:
Unlike
TSOptionalType, it is safe to skipTSRestTypebecause it is a prefix non-array-type operator, similar totypeof. Therefore I have removed theTSRestTypecheck in the intersection/union rule as well as the test.