Use .ts files with explicit reexports to solve name conflicts#17130
Merged
nicolo-ribaudo merged 2 commits intobabel:mainfrom Feb 14, 2025
Merged
Use .ts files with explicit reexports to solve name conflicts#17130nicolo-ribaudo merged 2 commits intobabel:mainfrom
.ts files with explicit reexports to solve name conflicts#17130nicolo-ribaudo merged 2 commits intobabel:mainfrom
Conversation
e80fd07 to
b70071c
Compare
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/58705 |
Member
Author
|
Merging this as-is, since it's just moving around functions across files to make TypeScript happy, without changing at all what is exported or any actual JS code. |
.ts files with explicit re-exports to solve builder conflicts.ts files with explicit reexports to solve name conflicts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1, Fixes #2The current approach we have with a
.d.tsfile that does not match the.jsfile really confuses tools that try to automatically generate docs for.tsfiles (e.g. jsr-io/jsr#957).This PR reworks how we handle the conflict in a way that does not rely on lying to TypeScript with a
uppercase.d.tsfile that does not matchuppercase.js, but instead uses a valid workaround for the problem of multipleexport *with conflicting names: explicitly listing the names I want to "win".This PR does not change the public API in any way, neither at the type level nor at the values level.
For ease of review, I split a file rename to its own commit, so that the second commit has a reasonable diff.