Skip to content

fix: incorret babel.config.cts test fixtures#17051

Merged
nicolo-ribaudo merged 1 commit intobabel:mainfrom
JLHwung:fix-failing-main
Jan 9, 2025
Merged

fix: incorret babel.config.cts test fixtures#17051
nicolo-ribaudo merged 1 commit intobabel:mainfrom
JLHwung:fix-failing-main

Conversation

@JLHwung
Copy link
Copy Markdown
Contributor

@JLHwung JLHwung commented Jan 8, 2025

Q                       A
Fixed Issues? Fixes current failing CI
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

Node.js 23.6 unflags the --experimental-strip-types support, which reveals incorrect .cts fixtures in our test suites.

@babel-bot
Copy link
Copy Markdown
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/58538

@nicolo-ribaudo
Copy link
Copy Markdown
Member

I also have some tests verifying how we interact with the native TS support, I'll push soon

@nicolo-ribaudo
Copy link
Copy Markdown
Member

I'm a bit blocked by the fact that we disallow .mts/.ts files, lets merge this to get CI green and I'll open a separate PR.

@nicolo-ribaudo nicolo-ribaudo merged commit d465131 into babel:main Jan 9, 2025
@nicolo-ribaudo nicolo-ribaudo deleted the fix-failing-main branch January 9, 2025 09:56
@github-actions github-actions Bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Apr 11, 2025
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Apr 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Fixes failing main

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants