Skip to content

fix: More accurate transform-typeof-symbol compat data#17031

Merged
nicolo-ribaudo merged 1 commit intobabel:mainfrom
liuxingbaoyu:typeof
Jan 8, 2025
Merged

fix: More accurate transform-typeof-symbol compat data#17031
nicolo-ribaudo merged 1 commit intobabel:mainfrom
liuxingbaoyu:typeof

Conversation

@liuxingbaoyu
Copy link
Copy Markdown
Member

Q                       A
Fixed Issues? Fixes #17030
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

Thanks to vitejs/vite#18959 (comment)
Unfortunately I tested manually on chrome 41 and it doesn't work with Symbol / Object(symbol).

@babel-bot
Copy link
Copy Markdown
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/58503

Copy link
Copy Markdown
Contributor

@JLHwung JLHwung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@JLHwung JLHwung added PR: Bug Fix 🐛 A type of pull request used for our changelog categories pkg: compat-data labels Jan 6, 2025
@nicolo-ribaudo nicolo-ribaudo merged commit 70fbc86 into babel:main Jan 8, 2025
@github-actions github-actions Bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Apr 10, 2025
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Apr 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: compat-data PR: Bug Fix 🐛 A type of pull request used for our changelog categories

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: When targeting Chrome 38 Symbol polyfill is included but not "typeof-symbol" transform

4 participants