Fix incomplete visitor keys#17019
Merged
JLHwung merged 6 commits intobabel:mainfrom Dec 12, 2024
Merged
Conversation
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/58472 |
nicolo-ribaudo
approved these changes
Dec 12, 2024
| node[field].type && | ||
| !( | ||
| ignoredVisitorKeysCheckTypes[type] === true || | ||
| ignoredVisitorKeysCheckTypes[type]?.[field] === true |
Member
There was a problem hiding this comment.
Suggested change
| ignoredVisitorKeysCheckTypes[type]?.[field] === true | |
| (ignoredVisitorKeysCheckTypes[type] && ignoredVisitorKeysCheckTypes[type][field] === true) |
to fix ci
Contributor
Author
There was a problem hiding this comment.
Thanks! Didn't notice this comment when I pushed the same fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
optionsproperty of theTSImportType.In this PR we ensure that for every AST node, its visitor keys always include the properties whose value is an AST node, with few exemptions. The new test detects quite a few incomplete visitor keys and they are now fixed in this PR.
This PR avoids builder changes so that it can be shipped in patch release. We can sync the builder with visitors in minor release.