perf: Improve transform performance a bit#16874
Closed
liuxingbaoyu wants to merge 1 commit into
Closed
Conversation
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/58319 |
liuxingbaoyu
commented
Sep 30, 2024
| ); | ||
| } else { | ||
| debug("discarding unknown inline input sourcemap"); | ||
| if (process.env.BABEL_8_BREAKING || !fromAst) { |
Member
Author
There was a problem hiding this comment.
Discussion welcome here.
I'm not sure if source map comments are included in program.comments when transformFromAst, and maybe we shouldn't use the fast path in Babel 8 either.
Member
Author
|
There is also a potential optimization of only traversing top-level statements, but I'm not sure if that is sufficient. |
a40f4bf to
ac18b81
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1, Fixes #2https://babeljs.io/docs/options#inputsourcemap
I don't know why
inputSourceMapistrueby default even thoughsourceMapsisfalse.This PR improves performance when the input does not contain source maps, avoiding
traverseFasttwice.