Skip to content

print @babel/traverse version on unknown AST types#16701

Merged
JLHwung merged 1 commit intobabel:mainfrom
JLHwung:polish-unknown-ast-type-message
Jul 30, 2024
Merged

print @babel/traverse version on unknown AST types#16701
JLHwung merged 1 commit intobabel:mainfrom
JLHwung:polish-unknown-ast-type-message

Conversation

@JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Jul 30, 2024

Q                       A
License MIT

Print @babel/traverse version when unknown AST types are seen. This should help users determine if they have duplicate @babel/traverse copies.

@babel-bot
Copy link
Collaborator

babel-bot commented Jul 30, 2024

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/57543

@JLHwung JLHwung force-pushed the polish-unknown-ast-type-message branch from ef75611 to 46e6a37 Compare July 30, 2024 17:53
@liuxingbaoyu
Copy link
Member

Unrelated to this PR, I noticed that our test262 was failing and was still green.

Copy link
Member

@nicolo-ribaudo nicolo-ribaudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Unfortunately, Next.js very rarely updates their Babel version so they won't get this change 😛

Copy link
Member

@liuxingbaoyu liuxingbaoyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea!

@JLHwung JLHwung merged commit 44efb5f into babel:main Jul 30, 2024
@JLHwung JLHwung deleted the polish-unknown-ast-type-message branch July 30, 2024 18:42
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Nov 2, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated A closed issue/PR that is archived due to age. Recommended to make a new issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants