Skip to content

add nextjs-10 e2e-test#16700

Merged
nicolo-ribaudo merged 11 commits intobabel:mainfrom
JLHwung:add-nextjs10-e2e-test
Jul 31, 2024
Merged

add nextjs-10 e2e-test#16700
nicolo-ribaudo merged 11 commits intobabel:mainfrom
JLHwung:add-nextjs10-e2e-test

Conversation

@JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Jul 30, 2024

Q                       A
Fixed Issues?
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

Added a new e2e test for Next.js 10, which roughly equals to webpack 4.44 + Babel 7.12.

The new test should be failing due to #16689.

@JLHwung JLHwung requested a review from nicolo-ribaudo July 30, 2024 16:55
@babel-bot
Copy link
Collaborator

babel-bot commented Jul 30, 2024 •
edited
Loading

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/57566

@JLHwung JLHwung force-pushed the add-nextjs10-e2e-test branch from cc9a2c2 to f07bc5f Compare July 30, 2024 17:02
@JLHwung JLHwung marked this pull request as draft July 30, 2024 19:02
@JLHwung JLHwung force-pushed the add-nextjs10-e2e-test branch 6 times, most recently from 125ba94 to e580d5a Compare July 30, 2024 20:08
@JLHwung JLHwung marked this pull request as ready for review July 30, 2024 20:13
@JLHwung
Copy link
Contributor Author

JLHwung commented Jul 30, 2024

"Redy" for review now, it's finally red in an expected way!

nicolo-ribaudo
nicolo-ribaudo approved these changes Jul 30, 2024
View reviewed changes
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets rebase and see if it passes :)

@nicolo-ribaudo nicolo-ribaudo mentioned this pull request Jul 30, 2024
Merged
@JLHwung JLHwung force-pushed the add-nextjs10-e2e-test branch from 26129f7 to 7de9844 Compare July 30, 2024 21:24
@nicolo-ribaudo
Copy link
Member

nicolo-ribaudo commented Jul 30, 2024

The CI failure is the same one I saw locally, but I believe it's not related to the breaking change we are working on fixing.

@JLHwung
Copy link
Contributor Author

JLHwung commented Jul 30, 2024

The CI failure is the same one I saw locally, but I believe it's not related to the breaking change we are working on fixing.

If we revert the package.json change, the test will be green:

https://github.com/babel/babel/actions/runs/10168808112/job/28124367505

So this must somehow related to the Babel version change. For the time being lets ignore this error and fix it in later PRs.

@nicolo-ribaudo nicolo-ribaudo force-pushed the add-nextjs10-e2e-test branch from 52fe193 to 5d14478 Compare July 31, 2024 09:53
@nicolo-ribaudo
Copy link
Member

nicolo-ribaudo commented Jul 31, 2024

With the latest commit, a demo I have locally is passing.

@nicolo-ribaudo
Copy link
Member

nicolo-ribaudo commented Jul 31, 2024

Come on

@nicolo-ribaudo nicolo-ribaudo force-pushed the add-nextjs10-e2e-test branch from 9c9b2e1 to 72447bb Compare July 31, 2024 10:18
@nicolo-ribaudo nicolo-ribaudo merged commit 08d5528 into babel:main Jul 31, 2024
@nicolo-ribaudo nicolo-ribaudo deleted the add-nextjs10-e2e-test branch July 31, 2024 11:41
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Nov 2, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo approved these changes

Assignees

No one assigned

Labels

area: tests outdated A closed issue/PR that is archived due to age. Recommended to make a new issue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JLHwung @babel-bot @nicolo-ribaudo