Add transform-regexp-modifiers to preset-env#16692
Merged
nicolo-ribaudo merged 13 commits intobabel:mainfrom Oct 23, 2024
Merged
Add transform-regexp-modifiers to preset-env#16692nicolo-ribaudo merged 13 commits intobabel:mainfrom
transform-regexp-modifiers to preset-env#16692nicolo-ribaudo merged 13 commits intobabel:mainfrom
Conversation
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/58206 |
04be1a0 to
a68c0cd
Compare
c68ede8 to
5e26e49
Compare
liuxingbaoyu
approved these changes
Sep 7, 2024
nicolo-ribaudo
approved these changes
Sep 8, 2024
Member
|
@JLHwung This is on the agenda for stage 4 at the TC39 meeting next week. |
Contributor
Author
|
Thanks. I will update this PR and rename the plugin if it reaches stage 4. |
Member
|
This reached consensus for stage 4. The extra change proposed by @JLHwung did not reach consensus, as the proposal has already been implemented as-is and implementations didn't consider it to be worth the change at this point. |
5e26e49 to
edd0590
Compare
| Please run these commands: | ||
| ``` | ||
| npm deprecate @babel/plugin-proposal-duplicate-named-capturing-groups-regex "This proposal has been merged to the ECMAScript standard and thus this plugin is no longer maintained. Please use @babel/plugin-transform-duplicate-named-capturing-groups-regex instead." | ||
| npm deprecate @babel/plugin-proposal-regexp-modifiers "This proposal has been merged to the ECMAScript standard and thus this plugin is no longer maintained. Please use @babel/plugin-transform-regexp-modifiers instead." |
Member
There was a problem hiding this comment.
Can you update the cronjob schedule to be at the end of november?
| "bugfix/transform-safari-id-destructuring-collision-in-function-expression": | ||
| "7.16.0", | ||
| "bugfix/transform-v8-static-class-fields-redefine-readonly": "7.12.0", | ||
| "proposal-regexp-modifiers": "7.19.0", |
Member
There was a problem hiding this comment.
Should this be transform-?
regexp-modifiers to preset-env shipped proposalstransform-regexp-modifiers to preset-env
liuxingbaoyu
approved these changes
Oct 8, 2024
5b8fe89 to
0330695
Compare
Contributor
Author
|
Rebased due to compat-data updates from Node 23 and Firefox 132. |
nicolo-ribaudo
approved these changes
Oct 23, 2024
Member
nicolo-ribaudo
left a comment
There was a problem hiding this comment.
This needs another rebase
0330695 to
ba2c6db
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the
regexp-modifiersplugin topreset-envnow that it just reaches Stage 4 in the TC39 Oct 2024 meeting.