Skip to content

Move ensureFunctionName to NodePath.prototype#16658

Merged
nicolo-ribaudo merged 3 commits intobabel:mainfrom
nicolo-ribaudo:remove-cycles-4
Jul 26, 2024
Merged

Move ensureFunctionName to NodePath.prototype#16658
nicolo-ribaudo merged 3 commits intobabel:mainfrom
nicolo-ribaudo:remove-cycles-4

Conversation

@nicolo-ribaudo
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo commented Jul 17, 2024

Q                       A
Fixed Issues? Fixes #1, Fixes #2
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

This should be the last non-peerDependencies cycle between packages :)

@nicolo-ribaudo nicolo-ribaudo added PR: New Feature 🚀 A type of pull request used for our changelog categories pkg: traverse labels Jul 17, 2024
@babel-bot
Copy link
Collaborator

babel-bot commented Jul 17, 2024

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/57471

@nicolo-ribaudo nicolo-ribaudo requested a review from JLHwung July 25, 2024 18:50
@nicolo-ribaudo nicolo-ribaudo force-pushed the feat-7.25.0/remove-cycles branch 2 times, most recently from bcac3c8 to 62b12b0 Compare July 26, 2024 10:30
@nicolo-ribaudo nicolo-ribaudo deleted the branch babel:main July 26, 2024 12:21
@nicolo-ribaudo nicolo-ribaudo changed the base branch from feat-7.25.0/remove-cycles to main July 26, 2024 12:22
@nicolo-ribaudo nicolo-ribaudo merged commit d364545 into babel:main Jul 26, 2024
@nicolo-ribaudo nicolo-ribaudo deleted the remove-cycles-4 branch July 26, 2024 15:58
@mikevoets
Copy link

Hello, because of this change we're seeing a breaking change: value.ensureFunctionName is not a function.

Can you please let us know how we fix this?

@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Nov 2, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: traverse PR: New Feature 🚀 A type of pull request used for our changelog categories

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants