Skip to content

Fix parens detection for object&function in as/satisfies#16648

Merged
nicolo-ribaudo merged 1 commit intobabel:mainfrom
nicolo-ribaudo:print-parens-as
Jul 16, 2024
Merged

Fix parens detection for object&function in as/satisfies#16648
nicolo-ribaudo merged 1 commit intobabel:mainfrom
nicolo-ribaudo:print-parens-as

Conversation

@nicolo-ribaudo
Copy link
Member

Q                       A
Fixed Issues? Fixes #16617 (comment)
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

I will also open a PR to avoid having to manually list all the case in isFirstInContext, but for now lets fix the regression the simple way.

@nicolo-ribaudo nicolo-ribaudo added PR: Bug Fix 🐛 A type of pull request used for our changelog categories i: regression labels Jul 16, 2024
@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/57367

@nicolo-ribaudo nicolo-ribaudo merged commit dcee3e4 into babel:main Jul 16, 2024
@nicolo-ribaudo nicolo-ribaudo deleted the print-parens-as branch July 16, 2024 09:14
@nicolo-ribaudo
Copy link
Member Author

@cpojer I'll release this soon :)

@cpojer
Copy link
Member

cpojer commented Jul 16, 2024

Thank you!

@zachbwh
Copy link

zachbwh commented Jul 16, 2024

Legendary! Thanks folks :)

@ArnaudBarre
Copy link

@nicolo-ribaudo I'm not sure if this normal but I think the v7.24.10 was no published to npm? A entry was added to the changelog and a git tag was added but nothing on npm or GH releases

@JLHwung
Copy link
Contributor

JLHwung commented Jul 21, 2024

@nicolo-ribaudo I'm not sure if this normal but I think the v7.24.10 was no published to npm? A entry was added to the changelog and a git tag was added but nothing on npm or GH releases

@babel/generator@7.24.10 was published, see https://www.npmjs.com/package/@babel/generator.

If you are using a lock file, you can try to remove @babel/generator from the lock file and run install again, your package manager should pick up the latest update.

@ArnaudBarre
Copy link

Oh sorry I looked at the core version that's why. Thanks!

@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 23, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

i: regression outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: generator PR: Bug Fix 🐛 A type of pull request used for our changelog categories

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants